Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump SonarAnalyzer.CSharp from 9.7.0.75501 to 9.8.0.76515 #1184

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 21, 2023

Bumps SonarAnalyzer.CSharp from 9.7.0.75501 to 9.8.0.76515.

Release notes

Sourced from SonarAnalyzer.CSharp's releases.

9.8

This release completes our effort to migrate all our symbolic execution rules from our old to our new engine: S2583 and S2589 are now migrated and see significant improvements. Also, they are now available for VB.NET. This being the last analyzer to migrate means that the engines don't run in parallel anymore, which significantly reduces analysis time. On top of that, our TokenTypeAnalyzer got a rework, which also improves performance in terms of analysis time and memory usage.

New Rules

  • 7648 - [VB.NET] S2589: Boolean expressions should not be gratuitous
  • 7647 - [VB.NET] S2583: Conditionally executed code should be reachable

Improvements

  • 7646 - [C#] Migrate S2583/S2589 to the new Symbolic Execution engine (C#)
  • 7369 - [C#] UtilityAnalyzer: Move to a syntax based classification of identifiers in the token type utility analyzer
  • 7697, 7803 - Update RSPEC before 9.8 release

False Positives

  • 7789 - [C#] Fix S2583/S2589 FP: Do not raise when condition is in the body of a lock statement.
  • 2496 - [C#] Fix S2583,S2589 FP: with nullable struct - update symbolic execution engine
  • 5601 - [C#] Fix S2583 FP: Variable change not detected inside a loop
  • 5002 - [C#] Fix S2583 FP: Property pattern match in else-if condition
  • 4755 - [C#] Fix S2583 FP: When using nullable boolean in if-elseif-else.
  • 4559 - [C#] Fix S2583 FP: User-defined explicit/implicit casts
  • 3288 - [C#] Fix S2583 FP: Invocation argument constraints should be independent
  • 2411 - [C#] Fix S2583 FP: confusing message for Guid comparison - should trigger S2589 instead
  • 739 - [C#] Fix S2583 FP: Condition evaluates to constant - false positive when casting floating point numbers
  • 7489 - [C#] Fix S2589 FP: Deconstructing a tuple in foreach loop
  • 7096 - [C#] Fix S2589 FP: || and property patterns
  • 5221 - [C#] Fix S2589 FP with nullable value types
  • 3910 - [C#] Fix S2589 FP and FN: Conditional access and pattern matching
  • 3565 - [C#] Fix S2589 FP: with StringSegment and literal null
  • 3353 - [C#] Fix S2589 FP: ref parameters in multithreading

False Negative

  • 6745 - [C#, VB.NET] Fix S2589 FN: Detect comparison between constant values
  • 4515 - [C#] Fix S2583 FN: Local functions
Commits
  • c1515ba UtilityAnalyzer: Wrong classifications: value in nameof (#7823)
  • dd0da2c UtilityAnalyzer: Wrong classifications: value in MemberAccess (#7822)
  • 360a2a5 UtilityAnalyzer: Wrong classifications: ref types (#7824)
  • 18f120f SE: Increase VisitCount for loop conditions to 3 (#7795)
  • dab5b34 UtilityAnalyzer: Optimize hot-path of TokenType analyzer (#7811)
  • 3d0f443 UtilityAnalyzer: Optimize SimpleMemberAccessExpression handling for the Token...
  • 287d36a UtilityAnalyzer: Annotate with performance sensitive (#7817)
  • e63e4e2 S1075: Add FN repro (#7816)
  • 3c5032e UtilityAnalyzer: Wrong classifications for AliasQualifiedNames (#7814)
  • 01782bd UtilityAnalyzer: Wrong classifcations for tuple elements (#7812)
  • Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
SonarAnalyzer.CSharp [>= 8.45.a, < 8.46]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 9.7.0.75501 to 9.8.0.76515.
- [Release notes](https://github.com/SonarSource/sonar-dotnet/releases)
- [Commits](SonarSource/sonar-dotnet@9.7.0.75501...9.8.0.76515)

---
updated-dependencies:
- dependency-name: SonarAnalyzer.CSharp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Aug 21, 2023
@linkdotnet
Copy link
Sponsor Collaborator

@egil There might be some false positives with Sonar 9.8. I already opened a ticket: SonarSource/sonar-dotnet#7849

For now, I would close that PR or we explicitly mute those errors.

@egil egil closed this Aug 23, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 23, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/nuget/SonarAnalyzer.CSharp-9.8.0.76515 branch August 23, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants